perf(account-tree-controller): scoped per-wallet sync for AccountTreeController#8929
Draft
hmalik88 wants to merge 7 commits into
Draft
perf(account-tree-controller): scoped per-wallet sync for AccountTreeController#8929hmalik88 wants to merge 7 commits into
AccountTreeController#8929hmalik88 wants to merge 7 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
hmalik88
changed the title
AccountTreeControllerAccountTreeController
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
After auditing performance of the account creation user flows, I observed that calling
AccountTreeController.syncWithUserStorage()after a single wallet's state changes (e.g., immediately after an SRP import) iterates every local entropy wallet, fetching wallet metadata + the full groups feature list for each one. When only the newly imported wallet has actually changed, that fanout is wasted bandwidth and slows the perceived "import complete" moment, especially for users with multiple existing wallets.This PR adds a scoped variant that syncs a single wallet by entropy source ID, leaving the existing full-sync API and behavior untouched. Consumers can swap
syncWithUserStorage()forsyncWalletWithUserStorage(entropySourceId)at SRP-import call sites to avoid the fanout. The new method is awaitable so sync-then-discover sequencing is preserved at the call site, defers to any in-flight full sync so callers cooperatively wait instead of racing, and does not fliphasAccountTreeSyncingSyncedAtLeastOnce(a scoped sync doesn't satisfy the first-full-sync contract).References
N/A
Checklist